[Mlir-commits] [mlir] [MLIR] Fix VectorEmulateNarrowType constant op mask bug (PR #116064)

llvmlistbot at llvm.org llvmlistbot at llvm.org
Fri Nov 15 07:39:29 PST 2024


================
@@ -129,6 +132,45 @@ static FailureOr<Operation *> getCompressedMaskOp(OpBuilder &rewriter,
       auto denseAttr = DenseElementsAttr::get(newMaskType, newMaskValues);
       newMask = rewriter.create<arith::ConstantOp>(loc, newMaskType, denseAttr);
     }
+  } else if (constantOp) {
+    assert(shape.size() == 1 && "expected 1-D mask");
----------------
lialan wrote:

Turns out it breaks things as some masks indeed created by other kinds of ops do have multiple dimensions. I am leaving it as is with a TODO for now. I will come back later. 

https://github.com/llvm/llvm-project/pull/116064


More information about the Mlir-commits mailing list