[Mlir-commits] [mlir] NFC sanity changes (PR #116201)

Abdul Raheem llvmlistbot at llvm.org
Thu Nov 14 02:26:27 PST 2024


https://github.com/abdulraheembeigh created https://github.com/llvm/llvm-project/pull/116201

NFC making a consistent indentation.
Corrected comment syntax. Changed // to ///
and nit grammatical change.

>From a7dd66c3a58d9b91abcc8d70dc2b3c8c13494bc8 Mon Sep 17 00:00:00 2001
From: Abdul Raheem <55028856+abdulraheembeigh at users.noreply.github.com>
Date: Thu, 14 Nov 2024 15:42:49 +0530
Subject: [PATCH 1/2] NFC change making consistent indentation

NFC change making consistent indentation.
---
 mlir/include/mlir/Dialect/MemRef/Utils/MemRefUtils.h | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

diff --git a/mlir/include/mlir/Dialect/MemRef/Utils/MemRefUtils.h b/mlir/include/mlir/Dialect/MemRef/Utils/MemRefUtils.h
index a761a77a407e87..462c809f035071 100644
--- a/mlir/include/mlir/Dialect/MemRef/Utils/MemRefUtils.h
+++ b/mlir/include/mlir/Dialect/MemRef/Utils/MemRefUtils.h
@@ -44,9 +44,9 @@ bool isStaticShapeAndContiguousRowMajor(MemRefType type);
 ///   is also scaled down by `dstBits`/`srcBits`. If `indices` is not provided
 ///   0, is returned for the linearized index.
 /// - If the size of the load/store is smaller than the linearized memref
-/// load/store, the memory region emulated is larger than the actual memory
-/// region needed. `intraDataOffset` returns the element offset of the data
-/// relevant at the beginning.
+///   load/store, the memory region emulated is larger than the actual memory
+///   region needed. `intraDataOffset` returns the element offset of the data
+///   relevant at the beginning.
 struct LinearizedMemRefInfo {
   OpFoldResult linearizedOffset;
   OpFoldResult linearizedSize;

>From 42eda8e130f57b33bd50a4090f16d322fc837ecb Mon Sep 17 00:00:00 2001
From: Abdul Raheem <55028856+abdulraheembeigh at users.noreply.github.com>
Date: Thu, 14 Nov 2024 15:53:21 +0530
Subject: [PATCH 2/2] NFC- corrected comment syntax

NFC- corrected comment syntax. Changed // to ///
and nit grammatical change.
---
 mlir/include/mlir/Dialect/MemRef/Utils/MemRefUtils.h | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

diff --git a/mlir/include/mlir/Dialect/MemRef/Utils/MemRefUtils.h b/mlir/include/mlir/Dialect/MemRef/Utils/MemRefUtils.h
index 462c809f035071..34ad279a07a8b5 100644
--- a/mlir/include/mlir/Dialect/MemRef/Utils/MemRefUtils.h
+++ b/mlir/include/mlir/Dialect/MemRef/Utils/MemRefUtils.h
@@ -69,8 +69,8 @@ getLinearizedMemRefOffsetAndSize(OpBuilder &builder, Location loc, int srcBits,
                                  int dstBits, OpFoldResult offset,
                                  ArrayRef<OpFoldResult> sizes);
 
-// Track temporary allocations that are never read from. If this is the case
-// it means both the allocations and associated stores can be removed.
+/// Track temporary allocations that are never read from. If this is the case
+/// it means both the allocations and associated stores can be removed.
 void eraseDeadAllocAndStores(RewriterBase &rewriter, Operation *parentOp);
 
 /// Given a set of sizes, return the suffix product.
@@ -106,7 +106,7 @@ computeStridesIRBlock(Location loc, OpBuilder &builder,
 /// memory is found (i.e. skip operations that alias the entire view).
 MemrefValue skipFullyAliasingOperations(MemrefValue source);
 
-/// Checks if two (memref) values are the same or are statically known to alias
+/// Checks if two (memref) values are the same or statically known to alias
 /// the same region of memory.
 inline bool isSameViewOrTrivialAlias(MemrefValue a, MemrefValue b) {
   return skipFullyAliasingOperations(a) == skipFullyAliasingOperations(b);



More information about the Mlir-commits mailing list