[Mlir-commits] [mlir] [mlir][Tensor] Retain discardable attrs in pack(cast) folder (PR #115772)
Mehdi Amini
llvmlistbot at llvm.org
Thu Nov 14 02:16:04 PST 2024
joker-eph wrote:
> We seem to have stopped at discardable attributes and have not added "preserved attributes". The transformation does not need to worry about the semantics of these preserved attributes.
Did you look at this link I posted above? https://discourse.llvm.org/t/rfc-implicit-propagation-of-dialect-attributes-best-effort/2657/
We never found a path forward for "preserved attributes", but we tried for some time.
> If these attributes are such that the meaning changes, well that is a burden on downstream users to adapt accordingly.
This is not how the system is designed, they should be dropped by default, it's not downstream problem. What you describe is something that could have been done, it is just not what is there with discardable attributes.
https://github.com/llvm/llvm-project/pull/115772
More information about the Mlir-commits
mailing list