[Mlir-commits] [mlir] [mlir][Vector] Remove trivial uses of vector.extractelement/vector.insertelement (1/N) (PR #116053)

[Kunwar Grover]

Groverkss wrote:

> Hey, thanks for the cleanup! Have you found any performance differences after the replacement? As I noted somewhere else, one of the reasons this hasn't been done sooner is because `vector.extract/insert` and `vector.extractelement/vector.insertelement` were not on pair in terms of folders/canonicalizations/transformations. There really was a performance difference the last time I looked at this.
> 
> We should also leave a bit more time for reviewers before landing. Thanks!

Sorry, I need to be a bit better at waiting on the merge button.

My experience was that vector.extract/insert actually had better folders and more things were folding. But this is a handwavy analysis. Let me try to run some benchmarks with this patch in IREE. I will post them on the original thread (I just noticed you had the same comment there and I missed it, sorry for that). I'll make sure to also send the benchmark numbers with any further patches I send. Thanks for being cautious on this.

https://github.com/llvm/llvm-project/pull/116053