[Mlir-commits] [mlir] [mlir][Linalg] Remove implicit zero rank vectors in vectorization (PR #116069)

[Andrzej Warzyński]

banach-space wrote:

Makes sense. 

> This patch moves this check from all operations, to only operations that do not support zero-rank operations yet. 

How did you identify these Ops? Mostly trying to make sure that we are not missing anything due to limited testing.

> This likely means that linalg vectorization isn't well tested for 0 rank tensors. I'm going to try to add more tests as well

+1 It's a corner case that's been barely tested, so that will be much appreciated. I should warn you though - some refactor/re-org of those tests is long-overdue 😅 

LGTM, but please give it 24hrs before landing. In case others want to chime in.

https://github.com/llvm/llvm-project/pull/116069