[Mlir-commits] [mlir] [MLIR] Add callback functions for ModuleToObject (PR #116007)

Fabian Mora llvmlistbot at llvm.org
Wed Nov 13 05:09:37 PST 2024


https://github.com/fabianmcg requested changes to this pull request.

The primary user of `ModuelToObject` in tree is `gpu-module-to-binary` and this change doesn't touch that pass. Oddly enough, this patch does modify `[NVVM|ROCDL]/Target.cpp`, so my questions are:

- How is this going to be used?
- Why is this needed if it's completely uncoupled from everything else?

Also, this requires unit tests.

https://github.com/llvm/llvm-project/pull/116007


More information about the Mlir-commits mailing list