[Mlir-commits] [mlir] [mlir][vector][nfc] Improve comments in `getCompressedMaskOp` (PR #115663)
Andrzej WarzyĆski
llvmlistbot at llvm.org
Tue Nov 12 07:56:54 PST 2024
================
@@ -36,24 +36,33 @@ using namespace mlir;
#define DBGSNL() (llvm::dbgs() << "\n")
#define LDBG(X) LLVM_DEBUG(DBGS() << X << "\n")
-/// Returns a compressed mask. The mask value is set only if any mask is present
-/// in the scale range. E.g., if `scale` equals to 2, and `intraDataOffset`
-/// equals to 1 (intraDataOffset strictly smaller than scale), the following
-/// mask:
+/// Returns a compressed mask. For example, when emulating `i8` with `i32` and
+/// when the number of source elements spans two `i32` elements, this method
+/// will compress `vector<8xi1>` into `vector<2xi1>`.
----------------
banach-space wrote:
Thank you for the discussion! @lialan , I've incorporated your suggestion (with additional tweaks from me).
https://github.com/llvm/llvm-project/pull/115663
More information about the Mlir-commits
mailing list