[Mlir-commits] [mlir] [mlir][LLVM] Add !invariant.group metadata to llvm.load and llvm.store (PR #115723)

[Tobias Gysi]

gysit wrote:

I believe this metadata type should be deleted. It is likely a leftover from the time where metadata was represented using operations and symbols. The type was then supposedly used to model metadata edges but apparently not the actual content of the metadata.

Today we have the distinct attribute which allows us to model metadata including "distinct nodes" using attributes. We should stick to this solution and model LLVM metadata using attributes in MLIR to avoid the issues @Dinistro pointed out.

https://github.com/llvm/llvm-project/pull/115723