[Mlir-commits] [mlir] [mlir][vector] Fix a crash in `VectorExtractOpConversion` (PR #115717)

Diego Caballero llvmlistbot at llvm.org
Mon Nov 11 18:02:19 PST 2024


https://github.com/dcaballe requested changes to this pull request.

> vector.extract %arg0[0]: f32 from vector<4x1xf32>

This doesn't look like a valid `vector.extract` to me. The source vector has two dimensions so either we pass two indices:

```
> vector.extract %arg0[0, 0]: f32 from vector<4x1xf32>
```

or

Return a `vector<1xf32>` or a `vector<f32>`.

I believe the fix here should be in the `vector.extract` verifier. 

https://github.com/llvm/llvm-project/pull/115717


More information about the Mlir-commits mailing list