[Mlir-commits] [mlir] [MLIR] support dynamic indexing of `vector.maskedload` in `VectorEmulateNarrowTypes` (PR #115070)
Han-Chung Wang
llvmlistbot at llvm.org
Mon Nov 11 16:17:48 PST 2024
https://github.com/hanhanW requested changes to this pull request.
Thanks a lot to @banach-space who provides so many useful review comments and keeps the code/comments heath! Also thanks to @lialan who helps the effort!
The PR itself looks good to me, just few comments.
IIRC, it adds the support when the source mask is from `vector.constant_mask`; the case that the source mask is from `vector.create_mask` is not supported yet. Am I correct? If so, could you add such information to the PR description?
https://github.com/llvm/llvm-project/pull/115070
More information about the Mlir-commits
mailing list