[Mlir-commits] [mlir] [mlir][vector] Fix a crash in `VectorExtractOpConversion` (PR #115717)

Andrzej WarzyƄski llvmlistbot at llvm.org
Mon Nov 11 10:17:18 PST 2024


================
@@ -1105,9 +1105,8 @@ class VectorExtractOpConversion
 
     // One-shot extraction of vector from array (only requires extractvalue).
     // Except for extracting 1-element vectors.
-    if (isa<VectorType>(resultType) &&
-        position.size() !=
-            static_cast<size_t>(extractOp.getSourceVectorType().getRank())) {
----------------
banach-space wrote:

Shouldn't there be a symmetric change for `vector.insert`?

https://github.com/llvm/llvm-project/pull/115717


More information about the Mlir-commits mailing list