[Mlir-commits] [mlir] [mlir][llvm] Add support for memset.inline (PR #115711)

[Christian Ulmann]

Dinistro wrote:

> Additionally, it could make sense to test that mem2reg and sroa work properly using your interface implementations. I added the relevant test files below. Since the logic is not duplicated it maybe sufficient to duplicate some test that covers the specialized code (possibly it is even sufficient to use the new intrinsic in some test cases). https://github.com/llvm/llvm-project/blob/4981f8cb72ea7d04da601c868763b38bdc11e74e/mlir/test/Dialect/LLVMIR/mem2reg-intrinsics.mlir https://github.com/llvm/llvm-project/blob/4981f8cb72ea7d04da601c868763b38bdc11e74e/mlir/test/Dialect/LLVMIR/sroa-intrinsics.mlir

I suggest to copy the existing memset tests there and maybe simplify them a bit if desired. Still, I would ensure that both cases are covered.



https://github.com/llvm/llvm-project/pull/115711