[Mlir-commits] [mlir] [MLIR][OpenMP] Prevent loop wrapper translation crashes (PR #115475)

[Sergio Afonso]

skatrak wrote:

> If there are currently no paths using this lowering, how did you find this bug?

> The danger with this is that someone can remove this piece of code in refactoring and think it was accidentally introduced since no test fails. Ideally, such code can be introduced in the first patch that needs it. You can organize such patches as two commits, where the first commit is this patch and the second commit is the one that needs it

Thank you both for your reviews. I found this bug through our current downstream support for 'distribute parallel do'. However, it will take a bit of time to get to upstreaming it, since other pieces must make it first, and there's a chance that we might want to rethink how we do it before then (potentially circumventing this code path). So I'll keep this PR around until we're ready to upstream the code that would trigger this failure, and I'll close it if we end up not needing it at that point.

https://github.com/llvm/llvm-project/pull/115475