[Mlir-commits] [mlir] add pattern for arith::UIToFPOp to VectorNarrowTypeRewritePatterns (PR #115485)

[Andrzej Warzyński]

================
@@ -262,6 +262,34 @@ func.func @aligned_sitofp_2d(%a: vector<8x32xi4>) -> vector<8x32xf32> {
   return %0 : vector<8x32xf32>
 }
 
+// CHECK-LABEL: func.func @aligned_uitofp(
----------------
banach-space wrote:

I've noticed `arith.sitofp` and `arith.trunci` include `@{.*}_base_case` test functions. Could you add a similar function here for consistency and symmetry?

Additionally, I believe it would be clearer if "base case" also appeared first (as in, "base case" followed by more involved cases). Also, "base case" itself may be a bit ambiguous. Based on my understanding, renaming these test functions might improve clarity, for example:

* `@aligned_sitofp` → `@aligned_sitofp_i4_to_f32`,
* `@aligned_extsi_base_case` → `@aligned_extsi_i4_to_i32`.

What do you think? If you agree, would you mind making these small additional changes? I realize this is slightly outside the PR's scope, but the impact would be positive without adding much noise.

https://github.com/llvm/llvm-project/pull/115485