https://github.com/gysit approved this pull request. LGTM modulo nit. `custom<LLVMOpAttrs>(attr-dict)` is apparently not necessary when looking at your tests. https://github.com/llvm/llvm-project/pull/115509