[Mlir-commits] [mlir] [mlir][spirv] Add spirv-to-llvm conversion for group operations (PR #115501)

Victor Perez llvmlistbot at llvm.org
Fri Nov 8 08:17:30 PST 2024


================
@@ -1038,18 +1040,23 @@ static LLVM::LLVMFuncOp lookupOrCreateSPIRVFn(Operation *symbolTable,
       symbolTable->getLoc(), name,
       LLVM::LLVMFunctionType::get(resultType, paramTypes));
   func.setCConv(LLVM::cconv::CConv::SPIR_FUNC);
-  func.setConvergent(true);
+  if (convergent) {
+    func.setConvergent(true);
+  }
----------------
victor-eds wrote:

```suggestion
  func.setConvergent(convergent);
```

`UnitAttr` are cool

https://github.com/llvm/llvm-project/pull/115501


More information about the Mlir-commits mailing list