[Mlir-commits] [mlir] [mlir][transf] Traits and interf. of alternatives, foreach, and yield. (PR #112169)

Ingo Müller llvmlistbot at llvm.org
Fri Nov 8 07:45:59 PST 2024


================
@@ -1358,7 +1368,8 @@ def VerifyOp : TransformDialectOp<"verify",
 }
 
 def YieldOp : TransformDialectOp<"yield",
-    [Terminator, DeclareOpInterfaceMethods<MemoryEffectsOpInterface>]> {
+    [Terminator, ReturnLike,
----------------
ingomueller-net wrote:

This change was proposed after #110322 broke things. But it got since then reversed, so it currently isn't "needed." The more I think about it, the more I doubt that #110322 is actually a good idea: it assumes that `FunctionOpInterface` has a `ReturnLike` terminator, which it shouldn't.

https://github.com/llvm/llvm-project/pull/112169


More information about the Mlir-commits mailing list