[Mlir-commits] [mlir] [mlir][transform] Overhaul `RegionBranchOpInterface` implementations. (PR #111408)

[Ingo Müller]

ingomueller-net wrote:

> One could also argue that the one-shot bufferization is using the interface wrong: AFAIU, `FunctionOpInterface` does not prescribe the ops implementing it to have `ReturnLike` terminators, so the pass should not assume this kind of terminators.

Thanks, @ftynse, for helping us decide. I think that my earlier statement (quoted here) is then correct: one cannot assume that `FunctionOpInterface` ops have `ReturnLike` terminators, so that change was not valid. That also corresponds to @ftynse's comment in #112615.

https://github.com/llvm/llvm-project/pull/111408