[Mlir-commits] [mlir] Make `FunctionOpInterface` check `ReturnLike` (PR #112615)

Oleksandr Alex Zinenko llvmlistbot at llvm.org
Fri Nov 8 07:38:33 PST 2024


https://github.com/ftynse requested changes to this pull request.

I don't see a sufficiently strong rationale to change the requirements of the built-in interface or trait. Return-like is used in dataflow sense outside functions. There are function-like operations that don't use return-like terminators (consider co-routines). If bufferization needs some additional guarantees/information from terminators to work, it is better to define a new, bufferization-specific interface and mark complying operations as implementing this interface. 

https://github.com/llvm/llvm-project/pull/112615


More information about the Mlir-commits mailing list