[Mlir-commits] [mlir] [MLIR][OpenMP] Prevent loop wrapper translation crashes (PR #115475)

Kiran Chandramohan llvmlistbot at llvm.org
Fri Nov 8 05:16:08 PST 2024


https://github.com/kiranchandramohan requested changes to this pull request.



> *[Reviewable](https://reviewable.io/reviews/llvm/llvm-project/115475)* status: 0 of 1 files reviewed, 1 unresolved discussion (waiting on @agozillon, @bhandarkar-pranav, @DominikAdamski, @ergawy, @jsjodin, @kparzysz, @Meinersbur, @mjklemm, @raghavendhra, @skatrak, @tblah, and @TIFitis)

___
*[`mlir/lib/Target/LLVMIR/Dialect/OpenMP/OpenMPToLLVMIRTranslation.cpp` line 482 at r1](https://reviewable.io/reviews/llvm/llvm-project/115475#-OBAuXhr0lTsRZE9mcbF:-OBAuXhr0lTsRZE9mcbG:b-ipecp3) ([raw file](https://github.com/llvm/llvm-project/blob/a18ac6599fb602c8b0abb17b9887a39c51d84e8e/mlir/lib/Target/LLVMIR/Dialect/OpenMP/OpenMPToLLVMIRTranslation.cpp#L482)):*
> ```cpp
>       builder.CreateBr(continuationBlock);
>       continue;
>     }
> ```

Can we write a test for this?


<!-- Sent from Reviewable.io -->


https://github.com/llvm/llvm-project/pull/115475


More information about the Mlir-commits mailing list