[Mlir-commits] [mlir] [mlir][linalg] unfold projected permutation. (PR #114704)
Javed Absar
llvmlistbot at llvm.org
Wed Nov 6 13:48:05 PST 2024
javedabsar1 wrote:
> > I really think UnfoldProjectedPermutation names what is pattern is doing - the transpose and broadcast can be seen as folded in via the affine map.
>
> I think that this is skewed towards the key implementation detail rather the transformation itself. To me, it's more like `specializeGenericByUnfoldingPermutation` or `decomposeGenericByUnfoldingPermutation`. I need to take another look at the pattern in search for inspiration, but today it's already too late 😅 Hopefully you see what I meant :)
`decomposeGenericByUnfoldingPermutation` works for me. Thanks for suggesting it :) Will change it everywhere.
https://github.com/llvm/llvm-project/pull/114704
More information about the Mlir-commits
mailing list