[Mlir-commits] [mlir] [mlir][linalg] unfold projected permutation. (PR #114704)

[Javed Absar]

javedabsar1 wrote:

> Nice, thanks!
> 
> I've skimmed through the tests to gauge what's going on and mostly looks fine. But I find `UnfoldProjectedPermutation` to be a very misleading name. I don't think that's the main thing here. Instead, this is expanding the "specialisation" logic, right?
> 
> There's a few tricky bits here, so I'd like to take another look.

I really think  `UnfoldProjectedPermutation`  names what is pattern is doing - the transpose and broadcast can be seen as folded in via the affine map. To identify we use an existing 'isProjectedPermutation` function, and what this rewrite is doing is unfolding what (at least conceptually) got folded in. 

I have re-written  the intro in the top of the .cpp file to make it more explicit / helpful.


But yeah, if you have a better name in mind would be glad to change this.

https://github.com/llvm/llvm-project/pull/114704