[Mlir-commits] [mlir] [mlir][tensor] Generalize/restrict `GeneralizeOuterUnitDimsPackOpPattern` (PR #114315)

Andrzej Warzyński llvmlistbot at llvm.org
Wed Nov 6 02:57:28 PST 2024


banach-space wrote:

I've just sent some updates addressing/implementing your suggestions for this revision. Two high-level comments:

* I am happy to remove `tensor.extract_slice` but will keep this change for a follow-on patch to avoid too many updates in a single PR.
* If there's a user for whom restricting `GeneralizeOuterUnitDimsPackOpPattern` causes issues, I am open to an immediate revert and will work on a more generic solution.

Most importantly, thank you for your in-depth review 🙏🏻 

https://github.com/llvm/llvm-project/pull/114315


More information about the Mlir-commits mailing list