[Mlir-commits] [mlir] [mlir][tensor] Generalize/restrict `GeneralizeOuterUnitDimsPackOpPattern` (PR #114315)

[Quinn Dawkins]

qedawkins wrote:

Ah I see your response before I sent my review.

> The current logic to compute the necessary sizes is quite convoluted. Adding support for the case mentioned above has been quite tricky. I can try to add support for non-unit not-tiled-outer-dims, but would really prefer avoid complexities that are not required.

I believe we were at one point relying on support for this downstream, but that might not be the case anymore (the pass I'm thinking of might have grown it's own simplified pattern for handling cases like this). Dropping support and fixing forward if the current implementation is broken (as you seem to be suggesting with your second point).

https://github.com/llvm/llvm-project/pull/114315