[Mlir-commits] [mlir] [mlir][acc] Simplify data entry/exit operation builders (PR #114880)
Valentin Clement バレンタイン クレメン
llvmlistbot at llvm.org
Tue Nov 5 08:26:02 PST 2024
clementval wrote:
> > LGTM. Can we use these in lowering?
>
> Potentially yes - but these are less useful in lowering where every argument to the builders is set up. These builders are more useful in passes which will be implemented outside of lowering such as applying "implicit data attributes" as required by OpenACC.
It would be nice to use it here https://github.com/llvm/llvm-project/blob/07443e9776f97090a776cba0288d65e90b6f1af4/flang/lib/Lower/OpenACC.cpp#L139-L140. We could simplify the code.
https://github.com/llvm/llvm-project/pull/114880
More information about the Mlir-commits
mailing list