[Mlir-commits] [mlir] [mlir][IR] Add `Block::isReachable` helper function (PR #114928)

River Riddle llvmlistbot at llvm.org
Mon Nov 4 23:04:00 PST 2024


River707 wrote:

Coming back to this PR after reading https://github.com/llvm/llvm-project/pull/114940 (which uses this function). I don't think we should add this kind of thing to Block, I'd rather push people to use DominanceInfo (which does this more optimally). Things like Dialect Conversion (which make a muck of blocks and all kinds of other things) are generally very unique compared to the majority of users. For API's on the core data structures, the APIs should (generally) be pushing for the best way to do something. 

https://github.com/llvm/llvm-project/pull/114928


More information about the Mlir-commits mailing list