[Mlir-commits] [mlir] [MLIR] [AMX] Utilize x86_amx type for AMX dialect in MLIR. (PR #111197)

Ilya Enkovich llvmlistbot at llvm.org
Mon Nov 4 12:27:08 PST 2024


ienkovich wrote:

@rengolin Since the dependency of `LLVMTypeConverter` on AMX dialect is a blocker for this patch, I made a change to remove `amx::TileType` conversion from the `LLVMTypeConverter` and instead add `ConvertToLLVMPatternInterface` interface implementation for AMX and moved `amx::TileType` conversion registration to `populateAMXLegalizeForLLVMExportPatterns`. This way, tiles can be properly converted by `convert-to-llvm` pass. It's not as convenient for users as handling `amx::TileType` directly in `LLVMTypeConverter`, but still much better than the current state.

Another option I was looking at was to extend `ConvertToLLVMPatternInterface` with `addTypeConversions` method and call it from `LLVMTypeConverter` constructor for all registered dialects that implement the interface. 

https://github.com/llvm/llvm-project/pull/111197


More information about the Mlir-commits mailing list