[Mlir-commits] [mlir] [MLIR] support dynamic indexing in `VectorEmulateNarrowTypes` (PR #114169)
Han-Chung Wang
llvmlistbot at llvm.org
Mon Nov 4 11:13:19 PST 2024
================
@@ -75,9 +77,6 @@ static FailureOr<Operation *> getCompressedMaskOp(OpBuilder &rewriter,
shape.back() = numElements;
auto newMaskType = VectorType::get(shape, rewriter.getI1Type());
if (createMaskOp) {
- // TODO: handle the case with non-zero intraDataOffset for CreateMaskOp.
- if (intraDataOffset != 0)
- return failure();
----------------
hanhanW wrote:
> Fixed wrong function comment of getCompressedMaskOp.
It looks like you are not only fixing the comment, but also changed the logic here? I think this fixes some lit tests in masked_load/store? Can you elaborate a little about the issue and how it's fixed in PR description?
https://github.com/llvm/llvm-project/pull/114169
More information about the Mlir-commits
mailing list