[Mlir-commits] [mlir] [MLIR] support dynamic indexing in `VectorEmulateNarrowTypes` (PR #114169)

Han-Chung Wang llvmlistbot at llvm.org
Mon Nov 4 11:13:19 PST 2024


================
@@ -129,26 +128,80 @@ static FailureOr<Operation *> getCompressedMaskOp(OpBuilder &rewriter,
   return newMask;
 }
 
+/// Extracts 1-D subvector from a 1-D vector. It is a wrapper function for
+/// emitting `vector.extract_strided_slice`.
 static Value extractSubvectorFrom(RewriterBase &rewriter, Location loc,
----------------
hanhanW wrote:

naming nit: I'd rename it to `staticallyExtractSubvectorFrom` to make a distinction between static case and dynamic case. 

https://github.com/llvm/llvm-project/pull/114169


More information about the Mlir-commits mailing list