https://github.com/banach-space commented: I've only had a chance to skim through the comments and tests and left a few nits. Will do a proper review later. There's a lot of threads on Discourse atm and it's tricky to co-ordinate everything 😅 https://github.com/llvm/llvm-project/pull/114704