[Mlir-commits] [mlir] [mlir] IntegerRangeAnalysis: add support for vector type (PR #112292)

[Andrzej Warzyński]

banach-space wrote:

This change looks good to me, and I appreciate the contribution—thank you!

I noticed this was merged just a few hours after approval by one of the two active reviewers. In cases like this, I like to quote LLVM's [Code Review policy](https://llvm.org/docs/CodeReview.html) (emphasis added):

> If approval is received very quickly, a patch author may also elect to wait before committing (and this is certainly considered polite for non-trivial patches). Especially given the global nature of our community, this waiting time should be at least 24 hours. Please also be mindful of weekends and major holidays.

While all rules were followed here, in cases where a patch has been in review for multiple weeks, I would certainly appreciate authors electing to wait that 24-hour period. When a review has taken this long, it often signals that there’s no immediate urgency to finalize the change.

Kind request for @krzysz00: when giving an unqualified LGTM, could you add a quick note, like "LGTM, I believe that all comments from reviewers have been addressed"? This would be helpful in ensuring everyone’s feedback is fully considered before merging. Thanks!

P.S. I am trying to add some clarifications to our coding review docs, but things are moving slowly: https://github.com/llvm/llvm-project/pull/111735. FYI, so this doesn't look like me moaning on random PRs.

https://github.com/llvm/llvm-project/pull/112292