[Mlir-commits] [mlir] [MLIR] support dynamic indexing in `VectorEmulateNarrowTypes` (PR #114169)

[Andrzej Warzyński]

================
@@ -129,9 +128,17 @@ static FailureOr<Operation *> getCompressedMaskOp(OpBuilder &rewriter,
   return newMask;
 }
 
+/// A wrapper function for emitting `vector.extract_strided_slice`. The vector
+/// has to be of 1-D shape.
----------------
banach-space wrote:

[nit] Rather than saying that the vector has to be 1-D, why not say "Extracts 1-D subvector from a 1-D vector". This way, the intent becomes clearer and the requirements are implied ;-)

Just so that you don't have to guess what I had in mind:

> /// A wrapper function to extract a 1-D subvector from the 1-D source vector.

Also, could you remind my why use `vector.extract_strided_slice` rather than `vector.extract`? 

Btw, none of this is a blocker for this PR. These are nice-to-have improvements, thanks!

https://github.com/llvm/llvm-project/pull/114169