[Mlir-commits] [mlir] [mlir][vector] Use notifyMatchFailure instead of assert in VectorLinearize (PR #93590)

Han-Chung Wang llvmlistbot at llvm.org
Thu May 30 16:27:51 PDT 2024


================
@@ -152,9 +152,10 @@ struct LinearizeVectorExtractStridedSlice final
   matchAndRewrite(vector::ExtractStridedSliceOp extractOp, OpAdaptor adaptor,
                   ConversionPatternRewriter &rewriter) const override {
     Type dstType = getTypeConverter()->convertType(extractOp.getType());
----------------
hanhanW wrote:

Why don't we just cast dstType to ShapedType here? I think it carries more information/methods v.s. `Type`. And you don't need to cast it in the below if condition.

https://github.com/llvm/llvm-project/pull/93590


More information about the Mlir-commits mailing list