[Mlir-commits] [mlir] [MLIR][SCF] Add an API to fuse consumer to a producer within scf loop (PR #88712)

[llvmlistbot at llvm.org]

MaheshRavishankar wrote:

> > The growing thread of discussion is making this quite difficult to follow/manage - I tried sifting through the comments to the best of my capabilities/understanding and have accordingly reverted the state to what it was previously (with lesser conflicts) and I believe we should be able to unblock landing this PR now and shift the discussion thread as an RFC.
> 
> Please add a note in the documentation of `getTiledImplementationFromResultTile` that, for most operations, it should be a trivial composition of two other methods. This will _significantly_ simplify the life of any downstream (other than yours) that will want to adopt your change.

A follow up here is indeed what would be good to add to the interface... I will update the documentation for `TilingInterface` to make things a bit more clear in terms of how the interface is setup.

> 
> And make sure you are comfortable with the level of understanding of the changes you are about to submit....

I consider myself the defacto maintainer of the TilingInterface (and its use in the tiling algorithm under SCF dialect using the interface). I have spent enough time here understand what is implemented here, and I am comfortable with this landing. Please redirect any concerns/issues you see to me, and I will try to address/contextualize them.

> 
> I am unblocking this. My arguments against the design still stand, but they date back to https://reviews.llvm.org/D127809, where I should have requested an RFC for changing something in lib/Interfaces. I won't make that mistake again, but @Abhishek-Varma is not the one who introduced that, so it's not up to him to resolve it.

Since this was originally introduced by me, I am happy to chat more. Value your concerns a lot here, but we might be approaching this from different angles, but there is no reason why we cant find a meet point. I am happy to setup some time to discuss your concerns offline and reach a shared understanding.

https://github.com/llvm/llvm-project/pull/88712