[Mlir-commits] [mlir] [MLIR] Improve translation of DISubrange. (PR #93689)

Christian Ulmann llvmlistbot at llvm.org
Thu May 30 05:17:49 PDT 2024


================
@@ -217,21 +217,33 @@ DISubprogramAttr DebugImporter::translateImpl(llvm::DISubprogram *node) {
 }
 
 DISubrangeAttr DebugImporter::translateImpl(llvm::DISubrange *node) {
-  auto getIntegerAttrOrNull = [&](llvm::DISubrange::BoundType data) {
-    if (auto *constInt = llvm::dyn_cast_or_null<llvm::ConstantInt *>(data))
+  auto getAttrOrNull =
+      [&](llvm::DISubrange::BoundType data) -> mlir::Attribute {
----------------
Dinistro wrote:

```suggestion
      [&](llvm::DISubrange::BoundType data) -> Attribute {
```
Nit: The `mlir::` namespace is not required in most of MLIR's cpp files.

https://github.com/llvm/llvm-project/pull/93689


More information about the Mlir-commits mailing list