[Mlir-commits] [mlir] [MLIR][SCF] Add an API to fuse consumer to a producer within scf loop (PR #88712)

[Oleksandr Alex Zinenko]

https://github.com/ftynse commented:

> The growing thread of discussion is making this quite difficult to follow/manage - I tried sifting through the comments to the best of my capabilities/understanding and have accordingly reverted the state to what it was previously (with lesser conflicts) and I believe we should be able to unblock landing this PR now and shift the discussion thread as an RFC.

Please add a note in the documentation of `getTiledImplementationFromResultTile` that, for most operations, it should be a trivial composition of two other methods. This will *significantly* simplify the life of any downstream (other than yours) that will want to adopt your change.

And make sure you are comfortable with the level of understanding of the changes you are about to submit....

I am unblocking this. My arguments against the design still stand, but they date back to https://reviews.llvm.org/D127809, where I should have requested an RFC for changing something in lib/Interfaces. I won't make that mistake again, but @Abhishek-Varma is not the one who introduced that, so it's not up to him to resolve it.

https://github.com/llvm/llvm-project/pull/88712