[Mlir-commits] [mlir] [mlir][emitc] Add EmitC index types (PR #93155)

Matthias Gehre llvmlistbot at llvm.org
Wed May 29 01:26:14 PDT 2024


================
@@ -76,7 +76,7 @@ def EmitC_ArrayType : EmitC_Type<"Array", "array", [ShapedTypeInterface]> {
 
     static bool isValidElementType(Type type) {
       return type.isIntOrIndexOrFloat() ||
-         emitc::isAnySizeTType(type) ||
+         emitc::isPointerWideType(type) ||
          llvm::isa<PointerType, OpaqueType>(type);
----------------
mgehre-amd wrote:

being pointer-wide doesn't qualify a type for being a vaild array element type. Maybe we want `return emitc::isIntegerIndexOrOpaqueType() || llvm::isa<PointerType>(type);` here?

https://github.com/llvm/llvm-project/pull/93155


More information about the Mlir-commits mailing list