[Mlir-commits] [mlir] [mlir][EmitC] Fix evaluation order of expressions (PR #93549)
Gil Rapaport
llvmlistbot at llvm.org
Tue May 28 21:19:33 PDT 2024
================
@@ -1316,7 +1316,11 @@ LogicalResult CppEmitter::emitOperand(Value value) {
FailureOr<int> precedence = getOperatorPrecedence(def);
if (failed(precedence))
return failure();
- bool encloseInParenthesis = precedence.value() < getExpressionPrecedence();
+
+ // Expressions with the same precedence need to be paranthesized, as
----------------
aniragil wrote:
I'd rephrase to "Sub-expressions with equal or lower precedence ..."
https://github.com/llvm/llvm-project/pull/93549
More information about the Mlir-commits
mailing list