[Mlir-commits] [mlir] [MLIR][Vector] Add DropUnitDimFromBroadcastOp pattern (PR #92938)

Hugo Trachino llvmlistbot at llvm.org
Tue May 28 04:29:50 PDT 2024


nujaa wrote:

FYI, I also have one last pattern ready which needs to go through some internal process before upstreaming. It matches a series of elementwise op to generate `vector.outerproduct`. Not a contraction. Would that still be lifting ?

> , IIUC, this change won't be needed. Given that getting rid of `vector.multi_reduction` is the long-term design goal (so it's bound to happen at some point), I'm wondering whether we shouldn't re-focus on that instead?

It does make sense. I can likely give it a look over the week. Happy to talk implementation details on a dedicated thread or something.

https://github.com/llvm/llvm-project/pull/92938


More information about the Mlir-commits mailing list