[Mlir-commits] [mlir] [MLIR][Vector]Generalize DropUnitDimFromElementwiseOps (PR #92934)

[Hugo Trachino]

nujaa wrote:


> Would `DropUnitDimFromElementwiseOps` help here at all? If yes, could you write tests for that? From what I can tell, that won't work as neither `vector.broadcast` nor `vector.transpose` are elementwise. But perhaps I missed something?

I simply found it weird elementwiseOps would only clean off outer dims when other similar patterns would not be limited by it. Simply some normalization. Also originally I thought I could reuse this method for Broadcast care but I realised unit unbroadcasted UnitDim were an issue.

> Would DropUnitDimFromElementwiseOps help here at all? If yes, could you write tests for that? From what I can tell, that won't work as neither vector.broadcast nor vector.transpose are elementwise. But perhaps I missed something?
That s why I submitted separate MRs to support BroadcastOps and TransposeOps.

> Btw, "vector-transfer-flatten.mlir" is failing with this change - not sure why pre-commit CI didn't capture that. In fact, looks like the tests didn't run 🤔

Hah, committed a fix directly inside Github but apparently I got too confident. 👼 


https://github.com/llvm/llvm-project/pull/92934