[Mlir-commits] [mlir] [mlir][arith] Clean up select op implementation (PR #93351)

[Jakub Kuderski]

kuhar wrote:

> I'm not sure I follow. These are general traits. The fact that only used by arith upstream doesn't make them arith traits.

AFAICT they are used as the verifier for a single op (`arith.select`) in the whole project, which makes it very specific to the type constraints used for the condition operand. The original naming was also poor: `AnyScalarTypeMatch` only matched booleans. For reason, I moved them to where they are used. I also grepped IREE and its submodules and didn't find any uses. Are there other reasons why we'd want to have it in `OpBase.td`?

https://github.com/llvm/llvm-project/pull/93351