[Mlir-commits] [flang] [mlir] [mlir] Align num elements type to LLVM ArrayType (PR #93230)

Valentin Clement バレンタイン クレメン llvmlistbot at llvm.org
Fri May 24 11:45:29 PDT 2024


================
@@ -632,7 +632,7 @@ llvm::Constant *mlir::LLVM::detail::getLLVMConstant(
           llvm::ElementCount::get(numElements, /*Scalable=*/isScalable), child);
     if (llvmType->isArrayTy()) {
       auto *arrayType = llvm::ArrayType::get(elementType, numElements);
-      SmallVector<llvm::Constant *, 8> constants(numElements, child);
+      std::vector<llvm::Constant *> constants(numElements, child);
       return llvm::ConstantArray::get(arrayType, constants);
----------------
clementval wrote:

So I tried to use `ConstantDataArray` for some example with i32 element type and I don't see a significant improvement. 

https://github.com/llvm/llvm-project/pull/93230


More information about the Mlir-commits mailing list