[Mlir-commits] [flang] [mlir] [mlir] Align num elements type to LLVM ArrayType (PR #93230)

[Mehdi Amini]

================
@@ -632,7 +632,7 @@ llvm::Constant *mlir::LLVM::detail::getLLVMConstant(
           llvm::ElementCount::get(numElements, /*Scalable=*/isScalable), child);
     if (llvmType->isArrayTy()) {
       auto *arrayType = llvm::ArrayType::get(elementType, numElements);
-      SmallVector<llvm::Constant *, 8> constants(numElements, child);
+      std::vector<llvm::Constant *> constants(numElements, child);
       return llvm::ConstantArray::get(arrayType, constants);
----------------
joker-eph wrote:

Did you see the second part of my comment when I opened this thread?

> And if not, we can go the ConstantDataArray route instead when the element type is scalar.

Have you looked at `ConstantDataArray` ? It won't be a splat, but still hopefully better?

https://github.com/llvm/llvm-project/pull/93230