[Mlir-commits] [mlir] [mlir] Fix race condition introduced in ThreadLocalCache (PR #93280)

Stella Laurenzo llvmlistbot at llvm.org
Fri May 24 02:10:03 PDT 2024


stellaraccident wrote:

I looked at both patches but haven't been online to see if you reverted the original. If not, I'd strongly prefer that you revert completely to the original state and then fix forward with more review.

These kind of races are very tricky, and while the performance is important, not getting into a fix forward loop is important. 

Thank you for doing this! But bugs here can have extreme impacts on everyone, and it is better to be systematic and careful.

https://github.com/llvm/llvm-project/pull/93280


More information about the Mlir-commits mailing list