[Mlir-commits] [mlir] [mlir][polynomial] python bindings (PR #93109)
Maksim Levental
llvmlistbot at llvm.org
Wed May 22 19:00:35 PDT 2024
https://github.com/makslevental updated https://github.com/llvm/llvm-project/pull/93109
>From 104bfc8caab85d25b907eb3e7bc7962143a94207 Mon Sep 17 00:00:00 2001
From: makslevental <maksim.levental at gmail.com>
Date: Wed, 22 May 2024 18:41:16 -0500
Subject: [PATCH 1/5] [mlir][polynomial] python bindings
---
mlir/include/mlir-c/Dialect/Polynomial.h | 25 +++++++++++++++++++
.../lib/Bindings/Python/DialectPolynomial.cpp | 23 +++++++++++++++++
mlir/lib/CAPI/Dialect/CMakeLists.txt | 10 ++++++++
mlir/lib/CAPI/Dialect/Polynomial.cpp | 17 +++++++++++++
mlir/python/CMakeLists.txt | 25 +++++++++++++++++--
mlir/python/mlir/dialects/Polynomial.td | 14 +++++++++++
mlir/python/mlir/dialects/polynomial.py | 6 +++++
mlir/test/python/dialects/polynomial.py | 24 ++++++++++++++++++
8 files changed, 142 insertions(+), 2 deletions(-)
create mode 100644 mlir/include/mlir-c/Dialect/Polynomial.h
create mode 100644 mlir/lib/Bindings/Python/DialectPolynomial.cpp
create mode 100644 mlir/lib/CAPI/Dialect/Polynomial.cpp
create mode 100644 mlir/python/mlir/dialects/Polynomial.td
create mode 100644 mlir/python/mlir/dialects/polynomial.py
create mode 100644 mlir/test/python/dialects/polynomial.py
diff --git a/mlir/include/mlir-c/Dialect/Polynomial.h b/mlir/include/mlir-c/Dialect/Polynomial.h
new file mode 100644
index 0000000000000..6381c0d9336f4
--- /dev/null
+++ b/mlir/include/mlir-c/Dialect/Polynomial.h
@@ -0,0 +1,25 @@
+//===-- mlir-c/Dialect/Polynomial.h - C API for LLVM --------------*- C -*-===//
+//
+// Part of the LLVM Project, under the Apache License v2.0 with LLVM
+// Exceptions.
+// See https://llvm.org/LICENSE.txt for license information.
+// SPDX-License-Identifier: Apache-2.0 WITH LLVM-exception
+//
+//===----------------------------------------------------------------------===//
+
+#ifndef MLIR_C_DIALECT_POLYNOMIAL_H
+#define MLIR_C_DIALECT_POLYNOMIAL_H
+
+#include "mlir-c/IR.h"
+
+#ifdef __cplusplus
+extern "C" {
+#endif
+
+MLIR_DECLARE_CAPI_DIALECT_REGISTRATION(Polynomial, polynomial);
+
+#ifdef __cplusplus
+}
+#endif
+
+#endif // MLIR_C_DIALECT_POLYNOMIAL_H
diff --git a/mlir/lib/Bindings/Python/DialectPolynomial.cpp b/mlir/lib/Bindings/Python/DialectPolynomial.cpp
new file mode 100644
index 0000000000000..66863aa28375c
--- /dev/null
+++ b/mlir/lib/Bindings/Python/DialectPolynomial.cpp
@@ -0,0 +1,23 @@
+//===- DialectPolynomial.cpp - 'polynomial' dialect submodule -------------===//
+//
+// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions.
+// See https://llvm.org/LICENSE.txt for license information.
+// SPDX-License-Identifier: Apache-2.0 WITH LLVM-exception
+//
+//===----------------------------------------------------------------------===//
+
+#include "mlir-c/Dialect/Polynomial.h"
+#include "mlir-c/IR.h"
+#include "mlir/Bindings/Python/PybindAdaptors.h"
+
+#include <pybind11/pybind11.h>
+#include <vector>
+
+namespace py = pybind11;
+using namespace llvm;
+using namespace mlir;
+using namespace mlir::python::adaptors;
+
+PYBIND11_MODULE(_mlirDialectsPolynomial, m) {
+ m.doc() = "MLIR Polynomial dialect";
+}
diff --git a/mlir/lib/CAPI/Dialect/CMakeLists.txt b/mlir/lib/CAPI/Dialect/CMakeLists.txt
index 4e141b60ff8cc..d2e330da33763 100644
--- a/mlir/lib/CAPI/Dialect/CMakeLists.txt
+++ b/mlir/lib/CAPI/Dialect/CMakeLists.txt
@@ -225,6 +225,16 @@ add_mlir_upstream_c_api_library(MLIRCAPIQuant
MLIRQuantDialect
)
+add_mlir_upstream_c_api_library(MLIRCAPIPolynomial
+ Polynomial.cpp
+
+ PARTIAL_SOURCES_INTENDED
+ LINK_LIBS PUBLIC
+ MLIRCAPIIR
+ MLIRPolynomialDialect
+)
+
+
add_mlir_upstream_c_api_library(MLIRCAPIOpenMP
OpenMP.cpp
diff --git a/mlir/lib/CAPI/Dialect/Polynomial.cpp b/mlir/lib/CAPI/Dialect/Polynomial.cpp
new file mode 100644
index 0000000000000..330fd05bb0521
--- /dev/null
+++ b/mlir/lib/CAPI/Dialect/Polynomial.cpp
@@ -0,0 +1,17 @@
+//===- Polynomial.cpp - C Interface for Polynomial dialect
+//--------------------------===//
+//
+// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions.
+// See https://llvm.org/LICENSE.txt for license information.
+// SPDX-License-Identifier: Apache-2.0 WITH LLVM-exception
+//
+//===----------------------------------------------------------------------===//
+
+#include "mlir-c/Dialect/Polynomial.h"
+#include "mlir/CAPI/Registration.h"
+#include "mlir/Dialect/Polynomial/IR/PolynomialDialect.h"
+
+using namespace mlir;
+
+MLIR_DEFINE_CAPI_DIALECT_REGISTRATION(polynomial, polynomial,
+ polynomial::PolynomialDialect)
diff --git a/mlir/python/CMakeLists.txt b/mlir/python/CMakeLists.txt
index d8f2d1989fdea..c3c3890e5debb 100644
--- a/mlir/python/CMakeLists.txt
+++ b/mlir/python/CMakeLists.txt
@@ -162,14 +162,22 @@ declare_mlir_dialect_python_bindings(
GEN_ENUM_BINDINGS)
declare_mlir_dialect_extension_python_bindings(
-ADD_TO_PARENT MLIRPythonSources.Dialects
-ROOT_DIR "${CMAKE_CURRENT_SOURCE_DIR}/mlir"
+ ADD_TO_PARENT MLIRPythonSources.Dialects
+ ROOT_DIR "${CMAKE_CURRENT_SOURCE_DIR}/mlir"
TD_FILE dialects/TransformPDLExtensionOps.td
SOURCES
dialects/transform/pdl.py
DIALECT_NAME transform
EXTENSION_NAME transform_pdl_extension)
+declare_mlir_dialect_python_bindings(
+ ADD_TO_PARENT MLIRPythonSources.Dialects
+ ROOT_DIR "${CMAKE_CURRENT_SOURCE_DIR}/mlir"
+ TD_FILE dialects/Polynomial.td
+ SOURCES
+ dialects/polynomial.py
+ DIALECT_NAME polynomial)
+
declare_mlir_dialect_python_bindings(
ADD_TO_PARENT MLIRPythonSources.Dialects
ROOT_DIR "${CMAKE_CURRENT_SOURCE_DIR}/mlir"
@@ -537,6 +545,19 @@ declare_mlir_python_extension(MLIRPythonExtension.Dialects.Quant.Pybind
MLIRCAPIQuant
)
+declare_mlir_python_extension(MLIRPythonExtension.Dialects.Polynomial.Pybind
+ MODULE_NAME _mlirDialectsPolynomial
+ ADD_TO_PARENT MLIRPythonSources.Dialects.polynomial
+ ROOT_DIR "${PYTHON_SOURCE_DIR}"
+ SOURCES
+ DialectPolynomial.cpp
+ PRIVATE_LINK_LIBS
+ LLVMSupport
+ EMBED_CAPI_LINK_LIBS
+ MLIRCAPIIR
+ MLIRCAPIPolynomial
+)
+
declare_mlir_python_extension(MLIRPythonExtension.Dialects.NVGPU.Pybind
MODULE_NAME _mlirDialectsNVGPU
ADD_TO_PARENT MLIRPythonSources.Dialects.nvgpu
diff --git a/mlir/python/mlir/dialects/Polynomial.td b/mlir/python/mlir/dialects/Polynomial.td
new file mode 100644
index 0000000000000..9567ea6e3c023
--- /dev/null
+++ b/mlir/python/mlir/dialects/Polynomial.td
@@ -0,0 +1,14 @@
+//===-- PolynomialOps.td - Entry point for PolynomialOps bind ------------*- tablegen -*-===//
+//
+// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions.
+// See https://llvm.org/LICENSE.txt for license information.
+// SPDX-License-Identifier: Apache-2.0 WITH LLVM-exception
+//
+//===----------------------------------------------------------------------===//
+
+#ifndef PYTHON_BINDINGS_POLYNOMIAL_OPS
+#define PYTHON_BINDINGS_POLYNOMIAL_OPS
+
+include "mlir/Dialect/Polynomial/IR/Polynomial.td"
+
+#endif
diff --git a/mlir/python/mlir/dialects/polynomial.py b/mlir/python/mlir/dialects/polynomial.py
new file mode 100644
index 0000000000000..dd9bee4aa3bd9
--- /dev/null
+++ b/mlir/python/mlir/dialects/polynomial.py
@@ -0,0 +1,6 @@
+# Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions.
+# See https://llvm.org/LICENSE.txt for license information.
+# SPDX-License-Identifier: Apache-2.0 WITH LLVM-exception
+
+from .._mlir_libs._mlirDialectsPolynomial import *
+from ._polynomial_ops_gen import *
\ No newline at end of file
diff --git a/mlir/test/python/dialects/polynomial.py b/mlir/test/python/dialects/polynomial.py
new file mode 100644
index 0000000000000..a405518671d6a
--- /dev/null
+++ b/mlir/test/python/dialects/polynomial.py
@@ -0,0 +1,24 @@
+# RUN: %PYTHON %s | FileCheck %s
+
+from mlir.ir import *
+from mlir.dialects import polynomial
+
+
+def constructAndPrintInModule(f):
+ print("\nTEST:", f.__name__)
+ with Context(), Location.unknown():
+ module = Module.create()
+ with InsertionPoint(module.body):
+ f()
+ print(module)
+ return f
+
+
+# CHECK-LABEL: TEST: test_smoke
+ at constructAndPrintInModule
+def test_smoke():
+ value = Attribute.parse("#polynomial.float_polynomial<0.5 + 1.3e06 x**2>")
+ output = Type.parse("!polynomial.polynomial<ring=<coefficientType=f32>>")
+ res = polynomial.constant(output, value)
+ # CHECK: polynomial.constant {value = #polynomial.float_polynomial<0.5 + 1.3E+6x**2>} : <ring = <coefficientType = f32>>
+ print(res)
>From 4ac1fd25c49b75619451a714f41b40743e2c58b3 Mon Sep 17 00:00:00 2001
From: Maksim Levental <maksim.levental at gmail.com>
Date: Wed, 22 May 2024 21:00:04 -0500
Subject: [PATCH 2/5] Update mlir/include/mlir-c/Dialect/Polynomial.h
Co-authored-by: Jeremy Kun <kun.jeremy at gmail.com>
---
mlir/include/mlir-c/Dialect/Polynomial.h | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/mlir/include/mlir-c/Dialect/Polynomial.h b/mlir/include/mlir-c/Dialect/Polynomial.h
index 6381c0d9336f4..52a3df5b475de 100644
--- a/mlir/include/mlir-c/Dialect/Polynomial.h
+++ b/mlir/include/mlir-c/Dialect/Polynomial.h
@@ -1,4 +1,4 @@
-//===-- mlir-c/Dialect/Polynomial.h - C API for LLVM --------------*- C -*-===//
+//===-- mlir-c/Dialect/Polynomial.h - C API for Polynomial --------*- C -*-===//
//
// Part of the LLVM Project, under the Apache License v2.0 with LLVM
// Exceptions.
>From 84700357690465a4684f8f59d99abb3254d014b0 Mon Sep 17 00:00:00 2001
From: Maksim Levental <maksim.levental at gmail.com>
Date: Wed, 22 May 2024 21:00:14 -0500
Subject: [PATCH 3/5] Update mlir/lib/CAPI/Dialect/Polynomial.cpp
Co-authored-by: Jeremy Kun <kun.jeremy at gmail.com>
---
mlir/lib/CAPI/Dialect/Polynomial.cpp | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/mlir/lib/CAPI/Dialect/Polynomial.cpp b/mlir/lib/CAPI/Dialect/Polynomial.cpp
index 330fd05bb0521..2fda7b0036207 100644
--- a/mlir/lib/CAPI/Dialect/Polynomial.cpp
+++ b/mlir/lib/CAPI/Dialect/Polynomial.cpp
@@ -1,5 +1,4 @@
-//===- Polynomial.cpp - C Interface for Polynomial dialect
-//--------------------------===//
+//===- Polynomial.cpp - C Interface for Polynomial dialect ----------------===//
//
// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions.
// See https://llvm.org/LICENSE.txt for license information.
>From c2f02de4d9e3aeecd64d84d3a798a7bc127fa461 Mon Sep 17 00:00:00 2001
From: Maksim Levental <maksim.levental at gmail.com>
Date: Wed, 22 May 2024 21:00:21 -0500
Subject: [PATCH 4/5] Update mlir/python/mlir/dialects/polynomial.py
Co-authored-by: Jeremy Kun <kun.jeremy at gmail.com>
---
mlir/python/mlir/dialects/polynomial.py | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/mlir/python/mlir/dialects/polynomial.py b/mlir/python/mlir/dialects/polynomial.py
index dd9bee4aa3bd9..5bd8084d5e5ef 100644
--- a/mlir/python/mlir/dialects/polynomial.py
+++ b/mlir/python/mlir/dialects/polynomial.py
@@ -3,4 +3,4 @@
# SPDX-License-Identifier: Apache-2.0 WITH LLVM-exception
from .._mlir_libs._mlirDialectsPolynomial import *
-from ._polynomial_ops_gen import *
\ No newline at end of file
+from ._polynomial_ops_gen import *
>From 4d75111f479305bc9ce37fc79cd18617e5fa5d8c Mon Sep 17 00:00:00 2001
From: Maksim Levental <maksim.levental at gmail.com>
Date: Wed, 22 May 2024 21:00:27 -0500
Subject: [PATCH 5/5] Update mlir/python/mlir/dialects/Polynomial.td
Co-authored-by: Jeremy Kun <kun.jeremy at gmail.com>
---
mlir/python/mlir/dialects/Polynomial.td | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/mlir/python/mlir/dialects/Polynomial.td b/mlir/python/mlir/dialects/Polynomial.td
index 9567ea6e3c023..b38cb05e47447 100644
--- a/mlir/python/mlir/dialects/Polynomial.td
+++ b/mlir/python/mlir/dialects/Polynomial.td
@@ -1,4 +1,4 @@
-//===-- PolynomialOps.td - Entry point for PolynomialOps bind ------------*- tablegen -*-===//
+//===-- Polynomial.td - Entry point for Polynomial bind ---*- tablegen -*-===//
//
// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions.
// See https://llvm.org/LICENSE.txt for license information.
More information about the Mlir-commits
mailing list