[Mlir-commits] [mlir] [mlir] Guard expensive string-based asserts behind EXPENSIVE_CHECKS (PR #93111)

[Jeff Niu]

================
@@ -303,7 +300,7 @@ class AttributeInterface
 protected:
   /// Returns the impl interface instance for the given type.
   static typename InterfaceBase::Concept *getInterfaceFor(Attribute attr) {
-#ifndef NDEBUG
+#ifdef EXPENSIVE_CHECKS
----------------
Mogball wrote:

Our compiler(s) are under development, so turning off asserts in downstream projects might not be as desirable. Having a slow compiler, however, is also affecting the developer experience.

https://github.com/llvm/llvm-project/pull/93111