[Mlir-commits] [mlir] [mlir] Guard expensive string-based asserts behind EXPENSIVE_CHECKS (PR #93111)
    Mehdi Amini 
    llvmlistbot at llvm.org
       
    Wed May 22 17:40:31 PDT 2024
    
    
  
================
@@ -303,7 +300,7 @@ class AttributeInterface
 protected:
   /// Returns the impl interface instance for the given type.
   static typename InterfaceBase::Concept *getInterfaceFor(Attribute attr) {
-#ifndef NDEBUG
+#ifdef EXPENSIVE_CHECKS
----------------
joker-eph wrote:
This is critical to check in asserts builds IMO. The promise is quite useless otherwise...
https://github.com/llvm/llvm-project/pull/93111
    
    
More information about the Mlir-commits
mailing list