[Mlir-commits] [mlir] [MLIR][Vector]Generalize DropUnitDimFromElementwiseOps (PR #92934)

[Andrzej Warzyński]

banach-space wrote:

> > > discussed [here](https://discourse.llvm.org/t/mlir-for-arm-sme-vectorizing-matmul-like-ops-as-part-of-a-broader-program/78603).
> > 
> > 
> > I don’t see unit dims mentioned in that particular thread. Did you mean some other thread?
> 
> Indeed, thanks for checking it out. updated to https://discourse.llvm.org/t/on-improving-arm-sme-lowering-resilience-in-mlir/78543/17?u=nujaa

Thanks, now I see what you meant :) Nit - I would add a bit more context in your PR summary to make it more self-contained (I find it super useful when commit msgs contain all the context). Specifically, I’d add that this was suggested in the discussion on improving the lowerings for ArmSME. And then add a link for folks interested in the discussion.

https://github.com/llvm/llvm-project/pull/92934