[Mlir-commits] [mlir] [mlir][emitc] Add EmitC lowering for arith.trunci, arith.extsi, arith.extui (PR #91491)

Simon Camphausen llvmlistbot at llvm.org
Wed May 22 06:38:07 PDT 2024


https://github.com/simon-camp approved this pull request.

Other than the formatting and missing newline this looks good to me.

Out of curiosity, what would be a good way of implementing the sign extension for i1? Doing unsigned extension, oring with `0b1111...00...` and casting back to signed?

https://github.com/llvm/llvm-project/pull/91491


More information about the Mlir-commits mailing list