[Mlir-commits] [mlir] merge code for llvm.emit_c_interface into convertFuncOpToLLVMFuncOp (PR #92986)

[Oleksandr Alex Zinenko]

ftynse wrote:

> I actually started with RewriterBase &. But RewriterBase doesn't have inlineRegionBefore and convertRegionTypes. I prefer RewriterBase & if it works. Do you have suggestion on it?

Thanks for checking. In this case, it looks easier to just keep the `ConversionPatternRewriter`. The alternative would be to pass in a callback, but that's too much fuss. Please address the comments about the test and this will be good to go.

https://github.com/llvm/llvm-project/pull/92986